Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve showpaths documentation #2195

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Dec 4, 2018

Fixes #2038


This change is Reviewable

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @scrye and @worxli)


go/tools/showpaths/paths.go, line 141 at r1 (raw file):

Usage: showpaths [flags]

Showpaths lists available paths between SCION ASes. Paths might be taken from a cache and therefore

Maybe use lowercase at start? Or just start with "Lists available paths ...".


go/tools/showpaths/paths.go, line 142 at r1 (raw file):

Showpaths lists available paths between SCION ASes. Paths might be taken from a cache and therefore
may be unhealthy. To check if paths are health, use -p to probe the paths and print its statuses.

I don't know if external users have the same concept of "path health" we do. Maybe rephrase to the following, s.t. it's a bit more obvious what path health means?

Paths might be retrieved from a local cache, and they might not forward traffic successfully (for example, if a network link went down). To probe if the paths are healthy, use -p.

Also, some typos:
s/health/healthy
s/its/their

Copy link
Contributor Author

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @scrye)


go/tools/showpaths/paths.go, line 141 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Maybe use lowercase at start? Or just start with "Lists available paths ...".

Done.


go/tools/showpaths/paths.go, line 142 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

I don't know if external users have the same concept of "path health" we do. Maybe rephrase to the following, s.t. it's a bit more obvious what path health means?

Paths might be retrieved from a local cache, and they might not forward traffic successfully (for example, if a network link went down). To probe if the paths are healthy, use -p.

Also, some typos:
s/health/healthy
s/its/their

Done.

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@worxli worxli merged commit bd4d5f0 into scionproto:master Dec 4, 2018
@worxli worxli deleted the showpaths-help branch December 4, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants