Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce MaxPaths in SCIOND #2084

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Enforce MaxPaths in SCIOND #2084

merged 1 commit into from
Nov 2, 2018

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Nov 2, 2018

Fixes #2025

This change is Reviewable

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@shitz shitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)

a discussion (no related file):
Please change the title of this PR to "Enforce MaxPaths in SCIOND" and add "Fixes #2025" to the description


@sustrik
Copy link
Contributor Author

sustrik commented Nov 2, 2018

a discussion (no related file):

Previously, shitz wrote…

Please change the title of this PR to "Enforce MaxPaths in SCIOND" and add "Fixes #2025" to the description

Done.


Copy link
Contributor

@shitz shitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)

a discussion (no related file):

Previously, sustrik (Martin Sustrik) wrote…

Done.

No, what I meant was to change the title and the description of the Github PR not the Git commit. If you add "Fixes #" to a PR description Github will automagically close the corresponding issue. Once you merge the PR, the Title of the PR will be used by default as the commit description.


@sustrik sustrik changed the title Make maxpaths arguments to showpaths work. Enforce MaxPaths in SCIOND Nov 2, 2018
@sustrik
Copy link
Contributor Author

sustrik commented Nov 2, 2018

a discussion (no related file):

Previously, shitz wrote…

No, what I meant was to change the title and the description of the Github PR not the Git commit. If you add "Fixes #" to a PR description Github will automagically close the corresponding issue. Once you merge the PR, the Title of the PR will be used by default as the commit description.

Hopefully done in the correct way now.


Copy link
Contributor

@shitz shitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

a discussion (no related file):

Previously, sustrik (Martin Sustrik) wrote…

Hopefully done in the correct way now.

Yup. Thx!


Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 6ca57d9 into scionproto:master Nov 2, 2018
@sustrik sustrik deleted the maxpaths branch November 5, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants