-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce MaxPaths in SCIOND #2084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)
a discussion (no related file):
Please change the title of this PR to "Enforce MaxPaths in SCIOND" and add "Fixes #2025" to the description
a discussion (no related file): Previously, shitz wrote…
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)
a discussion (no related file):
Previously, sustrik (Martin Sustrik) wrote…
Done.
No, what I meant was to change the title and the description of the Github PR not the Git commit. If you add "Fixes #" to a PR description Github will automagically close the corresponding issue. Once you merge the PR, the Title of the PR will be used by default as the commit description.
a discussion (no related file): Previously, shitz wrote…
Hopefully done in the correct way now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
a discussion (no related file):
Previously, sustrik (Martin Sustrik) wrote…
Hopefully done in the correct way now.
Yup. Thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
Fixes #2025
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)