Keep segments containing ISD-level loops

[worxli]

Fixes #2037

---

This change is 

[lukedirtwalker]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @worxli)

---

python/beacon_server/core.py, line 44 at r1 (raw file):

filter_ISD

I would name it filter_isd_loops then it is immediately clear what it filters.
Note that I think ISD should be lower case in the variable name, as in the rest of the code we also have stuff in lower case (isd_as, if_id)

---

python/beacon_server/core.py, line 160 at r1 (raw file):

            # Switched to a new ISD
            last_isd = curr_isd
            if curr_isd in isds and self.filter_ISD:

I would put the bool check in front of the list check since it is cheaper.

[worxli]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)

---

python/beacon_server/core.py, line 44 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

filter_ISD

I would name it filter_isd_loops then it is immediately clear what it filters.
Note that I think ISD should be lower case in the variable name, as in the rest of the code we also have stuff in lower case (isd_as, if_id)

Done.

---

python/beacon_server/core.py, line 160 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

I would put the bool check in front of the list check since it is cheaper.

Done.

[lukedirtwalker]

Reviewed 1 of 3 files at r2.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @worxli)

---

python/bin/beacon_server, line 41 at r2 (raw file):

                        '(Default: %s)' % get_default_sciond_path())
    parser.add_argument('--filter_isd_loops', default=False,
                        help='Filter ISD loops in Core Beacon Server (Default: False)')

As discussed offline please use action='store_true' so that we can use it without value (only flag --filter_isd_loops)

[lukedirtwalker]

Reviewed 1 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)

[lukedirtwalker]

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)

---

python/bin/beacon_server, line 40 at r3 (raw file):

default=False,

This is no longer needed.

[worxli]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

python/bin/beacon_server, line 40 at r3 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

default=False,

This is no longer needed.

Done.

[lukedirtwalker]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

[kormat]

Reviewed 1 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[kormat]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved