Update gopacket version #2035
Merged
Update gopacket version #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to a more recent version of gopacket, which includes the
following commit:
Attempt to reduce memory usage caused by enums.go strings.
commit-id: 8c5cfc5ae25c08c58287b22231251f3f9c155ec6
sgmonroy
force-pushed
the
update-gopacket
branch
from
143d456 to
8c1218c
Compare
lukedirtwalker
requested changes
Oct 25, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sgmonroy)
docker.sh, line 81 at r1 (raw file):
6G
Also needs to be 4G
sgmonroy
commented
Oct 25, 2018
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
docker.sh, line 81 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
6GAlso needs to be 4G
Done.
lukedirtwalker
approved these changes
Oct 25, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
lukedirtwalker
approved these changes
Oct 25, 2018
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to a more recent version of gopacket, which includes the
following commit:
Attempt to reduce memory usage caused by enums.go strings.
commit-id: 8c5cfc5ae25c08c58287b22231251f3f9c155ec6
This change is