Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS.go: Dockerize #2016

Merged
merged 2 commits into from
Nov 8, 2018
Merged

CS.go: Dockerize #2016

merged 2 commits into from
Nov 8, 2018

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Oct 22, 2018

This change is Reviewable

@oncilla oncilla requested a review from worxli October 22, 2018 12:56
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @oncilla and @worxli)


docker/perapp/app/Dockerfile.cert, line 4 at r1 (raw file):

COPY --from=scion_app_builder:latest /home/scion/go/src/github.com/scionproto/scion/bin/cert_srv /app/

ENTRYPOINT ["/sbin/su-exec", "/app/cert_srv", "-config", "/share/conf/csconfig.toml"]

Waiting for #1938

@oncilla oncilla force-pushed the cs-gen-docker branch 3 times, most recently from bc03432 to cf16d5b Compare November 1, 2018 12:06
Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @worxli)


docker/perapp/app/Dockerfile.cert, line 4 at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

Waiting for #1938

Done.

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 2 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 4f19a9e into scionproto:master Nov 8, 2018
@oncilla oncilla deleted the cs-gen-docker branch February 8, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants