Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Consistent setup #2014

Merged
merged 2 commits into from
Oct 23, 2018
Merged

lib: Consistent setup #2014

merged 2 commits into from
Oct 23, 2018

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Oct 19, 2018

Synchronize init order between services.
Log service startup message

fixes #2009


This change is Reviewable

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)


go/lib/env/logging.go, line 94 at r1 (raw file):

// LogSvcStarted should be called by services as soon as logging is initialized.
func LogSvcStarted(svcType, elemId string) {
	log.Info("Service started", "svc", svcType, "id", elemId)

This should be more visible. E.g. add =====================> to the start of the string.

Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @kormat and @lukedirtwalker)


go/lib/env/logging.go, line 94 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

This should be more visible. E.g. add =====================> to the start of the string.

Done.

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Synchronize init order between services.
Log service startup message (fixes scionproto#2009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All services must log a clear, consistent startup message
3 participants