-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Consistent setup #2014
lib: Consistent setup #2014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/lib/env/logging.go, line 94 at r1 (raw file):
// LogSvcStarted should be called by services as soon as logging is initialized. func LogSvcStarted(svcType, elemId string) { log.Info("Service started", "svc", svcType, "id", elemId)
This should be more visible. E.g. add =====================>
to the start of the string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @kormat and @lukedirtwalker)
go/lib/env/logging.go, line 94 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
This should be more visible. E.g. add
=====================>
to the start of the string.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Synchronize init order between services. Log service startup message (fixes scionproto#2009)
Synchronize init order between services.
Log service startup message
fixes #2009
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)