Add scion_path arg for python docker services #1975
Conversation
Otherwise they cannot connect to sciond, since they'll try default.sock. Running only end2end test with Python infra this problem didn't appear. When running cert_req_test the problem appeared with Python infra. When running Go-SD and Go-PS the problem also occured with the end2end test.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker, @worxli, and @kormat)
python/topology/generator.py, line 1269 at r1 (raw file):
entry['volumes'].append('${PWD}/%s:/share/conf:ro' % os.path.join(base, k)) entry['command'].append('--prom=%s' % _prom_addr_infra(v)) entry['command'].append('--sciond_path=%s' %
whitespaces?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @worxli and @kormat)
python/topology/generator.py, line 1269 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
whitespaces?
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @worxli and @kormat)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kormat)
Otherwise they cannot connect to sciond, since they'll try default.sock.
Running only end2end test with Python infra this problem didn't appear.
When running cert_req_test the problem appeared with Python infra.
When running Go-SD and Go-PS the problem also occured with the end2end test.
This change is