Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sd: "no paths found" logging is opaque #3294

Closed
kormat opened this issue Oct 31, 2019 · 2 comments · Fixed by #3306
Closed

sd: "no paths found" logging is opaque #3294

kormat opened this issue Oct 31, 2019 · 2 comments · Fixed by #3306
Assignees
@lukedirtwalker

Comments

@kormat
Copy link
Contributor

kormat commented Oct 31, 2019

When sciond can't find any paths:

2019-10-31 14:26:07.868232+0000 [EROR] No convergence in lookup debug_id=42f0a1eb iteration=3
2019-10-31 14:26:07.868241+0000 [EROR] Unable to get paths debug_id=42f0a1eb err="Segment lookup doesn't converge iterations="3""

"convergence" isn't something a user will understand (i certainly don't know what it means from looking at the logs).
@kormat kormat added the SCIOND label Oct 31, 2019
@kormat
Copy link
Contributor Author

kormat commented Oct 31, 2019

Also these log statements are ~mutually redundant.

@lukedirtwalker
Copy link
Collaborator

probably boils down to #3094

@lukedirtwalker lukedirtwalker mentioned this issue Nov 4, 2019
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Nov 4, 2019
@lukedirtwalker
segfetcher: Stop fetch loop on errors
527fcf7 
If we have an error we should not simply ignore it and continue processing.
Instead the fetcher now returns the error immediately.

Also
* do not continue resolving&fetching when 0 up/down segments are cached
* log sciond error code in debug
* remove duplicated log about convergence problem
* improve returned error when a timeout occurs in QUIC

Fixes scionproto#2721
Fixes scionproto#3293
Fixes scionproto#3294
Fixes scionproto#3094
@lukedirtwalker lukedirtwalker self-assigned this Nov 4, 2019
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Nov 4, 2019
@lukedirtwalker
segfetcher: Stop fetch loop on errors
7e83efd 
If we have an error we should not simply ignore it and continue processing.
Instead the fetcher now returns the error immediately.

Also
* do not continue resolving&fetching when 0 up/down segments are cached
* log sciond error code in debug
* remove duplicated log about convergence problem
* improve returned error when a timeout occurs in QUIC

Fixes scionproto#2721
Fixes scionproto#3293
Fixes scionproto#3294
Fixes scionproto#3094
lukedirtwalker added a commit that referenced this issue Nov 4, 2019
@lukedirtwalker
segfetcher: Stop fetch loop on errors (#3306)
dd9be37 
If we have an error we should not simply ignore it and continue processing.
Instead the fetcher now returns the error immediately.

Also
* do not continue resolving&fetching when 0 up/down segments are cached
* log sciond error code in debug
* remove duplicated log about convergence problem
* improve returned error when a timeout occurs in QUIC

Fixes #2721
Fixes #3293
Fixes #3294
Fixes #3094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

segfetcher: Stop fetch loop on errors lukedirtwalker/scion
2 participants
@lukedirtwalker @kormat