Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig_failover test: Reply caching on startup of test topology is problematic #3125

Closed
lukedirtwalker opened this issue Sep 9, 2019 · 2 comments · Fixed by #3550
Closed

sig_failover test: Reply caching on startup of test topology is problematic #3125

lukedirtwalker opened this issue Sep 9, 2019 · 2 comments · Fixed by #3550

Comments

@lukedirtwalker
Copy link
Collaborator

sciond and the PS cache replies they got from remote server for a certain amount of time (5min configurable). During the startup of the test topology it might be that no all paths are yet registered. If some paths are taken down, it could be that connectivity is lost.

For example in build https://buildkite.com/scionproto/acceptance/builds/365#96eaca46-463a-49df-99c0-bead1f3cd73c
The path via br2 is initially registered and cached. Then sciond doesn't receive a revocation therefore it never hands out a new path, just the broken cached one.
@oncilla
Copy link
Contributor

oncilla commented Oct 2, 2019

This also applies to the path manager.
The path manager does not receive a revocation, thus it will not bother querying sciond for new paths.

@oncilla
Copy link
Contributor

oncilla commented Oct 2, 2019

also see #1390

@scrye scrye mentioned this issue Dec 20, 2019
Merged
scrye added a commit that referenced this issue Dec 27, 2019
@scrye
Migrate sig_failover_acceptance to bazel (#3550)
aba89e7 
Also:
- add support for plugging a configurable fake SCIOND into the SIG; this
makes it possible to run SIG tests without a control-plane
- change the entrypoint of docker debug images from su-exec; it is not needed
in debugging/development environments
- change UDP proxy command line options; the new proxy uses
deterministic ports when forwarding data
- add config option AllowRunAsRoot to allow running the SIG and Go
dispatcher as root
- use ping instead of using go/acceptance/sig_ping_acceptance for
connectivity tests
- use static docker-compose file instead of topology generator
to set up sig_failover_acceptance; the generator builds more
files than necessary for the test, and also does not have
support for fake sciond data; doing it directly from hand crafted
files is easier to inspect, modify and debug;
- remove BS, CS, PS, SD, BRs from sig_failover_acceptance

Fixes #3125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate sig_failover_acceptance to bazel
2 participants
@lukedirtwalker @oncilla