Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS: segreq handler should log more about fetcher errors and reply with NACK/error #3091

Closed
lukedirtwalker opened this issue Sep 4, 2019 · 0 comments · Fixed by #3092
Closed
Labels
bug Something isn't working

Comments

@lukedirtwalker
Copy link
Collaborator

If the segfetcher logic in the PS returns an error, the handler silently returns, we should log the error and return a negative reply to the client.

Problematic code:

segs, err := h.fetcher.FetchSegs(ctx,
segfetcher.Request{Src: segReq.SrcIA(), Dst: segReq.DstIA()})
if err != nil {
return infra.MetricsErrInternal
}

and missing logging in:
if err = rw.SendSegReply(ctx, reply); err != nil {
return infra.MetricsErrInternal
}

@lukedirtwalker lukedirtwalker added bug Something isn't working PS labels Sep 4, 2019
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Sep 4, 2019
Instead of silently bailing out.

Fixes scionproto#3091
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Sep 4, 2019
Instead of silently bailing out.

Fixes scionproto#3091
lukedirtwalker added a commit that referenced this issue Sep 4, 2019
Instead of silently bailing out.

Fixes #3091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant