Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery: Enable initial connection check #2431

Closed
oncilla opened this issue Feb 8, 2019 · 0 comments · Fixed by #2459
Closed

Discovery: Enable initial connection check #2431

oncilla opened this issue Feb 8, 2019 · 0 comments · Fixed by #2459
Assignees
@oncilla
Milestone
Q1S2

Comments

@oncilla
Copy link
Contributor

oncilla commented Feb 8, 2019

Enable the idiscovery library to initially check that a connection to the discovery service is possible.

This can be enabled in the config by setting discovery.InitialConnectPeriod to a non-zero value.
This check is only executed, when either discovery.static or discovery.dynamic is enabled.

If the process fails to connect, there are two possible actions that are taken (configurable):

  • Fatal: Exit process with error
  • Ignore: Ignore, and keep the periodic queries running
@oncilla oncilla self-assigned this Feb 8, 2019
@oncilla oncilla added this to the Q1S2 milestone Feb 8, 2019
@oncilla oncilla mentioned this issue Feb 14, 2019
Merged
oncilla added a commit that referenced this issue Feb 15, 2019
@oncilla
Discovery: Initial connection check (#2459)
12cff7e 
Enables the `idiscovery` library to initially check that topologies can be successfully fetched from the discovery service.
On start up, the discovery service is queried every second until a valid response is received or the `InitialPeriod` has passed. If that period has passed, and no valid topology has been received,
the process will take the configured fail action:
* `Fatal`: Exit process with error
* `Ignore`: Ignore, and keep the periodic queries running

fixes #2431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oncilla oncilla

Labels
None yet
Projects
None yet
Milestone
Q1S2
Development

Successfully merging a pull request may close this issue.

Discovery: Initial connection check oncilla/scion
1 participant
@oncilla