Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml: fix casing in config files #2412

Closed
lukedirtwalker opened this issue Jan 31, 2019 · 2 comments · Fixed by #3684
Closed

toml: fix casing in config files #2412

lukedirtwalker opened this issue Jan 31, 2019 · 2 comments · Fixed by #3684
Assignees
@lukedirtwalker
Labels
i/breaking change PR that breaks forwards or backwards compatibility
Milestone
S01 E05

Comments

@lukedirtwalker
Copy link
Collaborator

According to the spec toml is case sensitive.
While the go lib currently also matches case insensitive (https://godoc.org/github.com/BurntSushi/toml#hdr-Key_mapping) we should not rely on this.
@oncilla
Copy link
Contributor

oncilla commented Jan 31, 2019

What style should we go for?

[logging]
  [logging.file]
    Level = "debug"

vs

[Logging]
  [Logging.File]
    Level = "debug"

@oncilla oncilla self-assigned this Jan 31, 2019
@scrye
Copy link
Contributor

scrye commented Feb 18, 2020

We should go for snake_case, so it's similar to our JSON files.

@scrye scrye added the i/breaking change PR that breaks forwards or backwards compatibility label Feb 18, 2020
@scrye scrye added this to the S01 E04 milestone Feb 18, 2020
@scrye scrye modified the milestones: S01 E04, S01 E05 Mar 3, 2020
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Mar 10, 2020
@lukedirtwalker
toml: use snake_case remove unused properties
0f02329 
Remove all currently unused configuration options.
Change all config options to snake_case.

Fixes scionproto#2412
@lukedirtwalker lukedirtwalker mentioned this issue Mar 10, 2020
Merged
lukedirtwalker added a commit that referenced this issue Mar 10, 2020
@lukedirtwalker
toml: use snake_case remove unused properties (#3684)
5a03123 
Remove all currently unused configuration options.
Change all config options to snake_case.

Fixes #2412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
i/breaking change PR that breaks forwards or backwards compatibility
Projects
None yet
Milestone
S01 E05
Development

Successfully merging a pull request may close this issue.

toml: use snake_case remove unused properties lukedirtwalker/scion
3 participants
@lukedirtwalker @scrye @oncilla