Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to common library code #2329

Closed
3 of 7 tasks
shitz opened this issue Jan 13, 2019 · 2 comments
Closed
3 of 7 tasks

Add metrics to common library code #2329

shitz opened this issue Jan 13, 2019 · 2 comments
Assignees
@lukedirtwalker

Comments

@shitz
Copy link
Contributor

shitz commented Jan 13, 2019 •
edited by lukedirtwalker
Loading

@shitz shitz added this to the Q1S1 milestone Jan 13, 2019
@kormat
Copy link
Contributor

kormat commented Jan 14, 2019

Messenger doesn't have access to packet bytes, but it could at least keep track of messages sent/received by type.

@lukedirtwalker lukedirtwalker mentioned this issue Jan 17, 2019
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Jan 18, 2019
@lukedirtwalker
TrustDB: Add metrics wrapper
8d3d065 
Rationale:
The error counters help to detect where an issue of a service might be (i.e. in this case the DB).
The total counters give an idea on the pressure on the DB.

Contributes scionproto#2329
@lukedirtwalker lukedirtwalker mentioned this issue Jan 18, 2019
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Jan 22, 2019
@lukedirtwalker
TrustDB: Add metrics wrapper
585ab25 
Rationale:
The error counters help to detect where an issue of a service might be (i.e. in this case the DB).
The total counters give an idea on the pressure on the DB.

Contributes scionproto#2329
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Jan 22, 2019
@lukedirtwalker
TrustDB: Add metrics wrapper
8bde4ba 
Rationale:
The error counters help to detect where an issue of a service might be (i.e. in this case the DB).
The total counters give an idea on the pressure on the DB.

Contributes scionproto#2329
lukedirtwalker added a commit that referenced this issue Jan 22, 2019
@lukedirtwalker
TrustDB: Add metrics wrapper (#2362)
ef909ac 
Rationale:
The result counters help to detect where an issue of a service might be (i.e. in this case the DB).
The total counters give an idea on the pressure on the DB.

Contributes #2329
@lukedirtwalker lukedirtwalker mentioned this issue Jan 25, 2019
Merged
lukedirtwalker added a commit that referenced this issue Jan 25, 2019
@lukedirtwalker
messenger: Add metrics (#2380)
7991602 
Contributes #2329
@shitz shitz modified the milestones: Q1S1, Q1S2 Jan 25, 2019
@lukedirtwalker lukedirtwalker mentioned this issue Jan 30, 2019
Merged
lukedirtwalker added a commit that referenced this issue Feb 22, 2019
@lukedirtwalker
Handlers: Add metrics (#2407)
32bb054 
A handler that is registered at the messenger will now have metrics by default.
There are three metrics:
in_calls_total: counts the total received requests.
in_results_total: counts the results of the received requests.
in_calls_latency: a histogram of the latency of the requests.
Analogous to in_* the current messenger metrics (for outgoing requests) 
have been renamed to out_*.

Also fixes the registration of messenger metrics (init() doesn't work because 
we don't want to register on the default Prometheus registerer).

Note that not all handlers always return the correct result/status,
that will be done in separate commits.

Contributes #2329, #2330, #1819
@scrye scrye removed this from the Q1S2 milestone Feb 26, 2019
@lukedirtwalker
Copy link
Collaborator

This is issue has been superseded by multiple issues labeled monitoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukedirtwalker @scrye @shitz @kormat