Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Go service configs to internal config packages #2311

Closed
scrye opened this issue Jan 9, 2019 · 0 comments
Closed

Move Go service configs to internal config packages #2311

scrye opened this issue Jan 9, 2019 · 0 comments
Assignees
@scrye

Comments

@scrye
Copy link
Contributor

scrye commented Jan 9, 2019

Go services contain one Config type in the main package, and a hard-coded mirror of the type in internal/**config package. The mirror type is used in tests, but the mirror can diverge if the type in the main package is refactored.

We might be able to get rid of the duplication (and have the actual type be tested), by using a single type definition in the internal/**config package.
@scrye scrye self-assigned this Jan 9, 2019
@scrye scrye mentioned this issue Jan 16, 2019
Merged
scrye added a commit that referenced this issue Jan 16, 2019
@scrye
Reduce code duplication in service configs (#2351)
8ea849d 
Fixes #2311. This reduces some type duplication in config tests, and makes configs more self-contained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scrye scrye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scrye