Treat null as undefined in match method of SCIMMY.Types.Filter class
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escaped string values Specifically, when the word token follows a comparator token. Ideally, this shouldn't be needed as strings would be properly wrapped.
…e to boolean Only cast from string to boolean when comparing for equality, and when actual value is also a boolean.
…risons in remove ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a filter is instantiated with an expression that looks for equality of "empty" values (e.g.
value eq null), thematchmethod will strictly compare against the valuenull. This comparison will always fail, asnullis treated as undefined in attribute coercion.The
matchmethod has been updated to treatnullasundefinedfor equality comparison purposes (fixes #34). Additionally, the internal tokenise method has been updated to correctly detect unescaped string values that begin with numbers. The test fixtures for the filter class have also been updated to verify the expected behaviour as above.