Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lila documentationfolders #144

Merged
merged 7 commits into from
Sep 17, 2022
Merged

Lila documentationfolders #144

merged 7 commits into from
Sep 17, 2022

Conversation

Lila-braff
Copy link
Collaborator

Fixes #137 .

Description of the Change

Checklist

Please check all that apply to your proposed changes

  • HTML code change
  • Added package dependency
  • Added data
  • Changed django model
  • Documentation change
  • Added or changed TaskRunner

Additional context

@Lila-braff Lila-braff marked this pull request as ready for review September 14, 2022 20:58
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 62.09% // Head: 62.09% // No change to project coverage 👍

Coverage data is based on head (e9cb089) compared to base (bf0f16c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   62.09%   62.09%           
=======================================
  Files          21       21           
  Lines        1583     1583           
=======================================
  Hits          983      983           
  Misses        600      600           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@astrophpeter astrophpeter self-requested a review September 17, 2022 19:12
Copy link
Collaborator

@astrophpeter astrophpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments, very close!

docs/index.rst Outdated Show resolved Hide resolved
@Lila-braff
Copy link
Collaborator Author

hopefully that fixed it! I am still confused by the merge conflict. I just don't understand what that means, why it happened, and how I fix it!

@Lila-braff
Copy link
Collaborator Author

sorry this issue has taken me a minute.

Copy link
Collaborator

@astrophpeter astrophpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice work, will merge shortly!

@astrophpeter astrophpeter merged commit 7152702 into main Sep 17, 2022
@astrophpeter astrophpeter deleted the lila-documentationfolders branch September 17, 2022 23:12
djones1040 pushed a commit that referenced this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize documentation files
2 participants