Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for the fixed footer #117

Merged
merged 4 commits into from
Aug 18, 2022
Merged

updates for the fixed footer #117

merged 4 commits into from
Aug 18, 2022

Conversation

SamLaiiii
Copy link
Collaborator

Fixes issues # 112

Description of the Change

add the style(especially for the position) at the footer in base.html file

Checklist

Please check all that apply to your proposed changes

  • HTML code change
  • Added package dependency
  • Added data
  • Changed django model
  • Documentation change
  • Added or changed TaskRunner

Additional context

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #117 (1c6b6d4) into main (55fb96d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files          18       18           
  Lines        1638     1638           
=======================================
  Hits          910      910           
  Misses        728      728           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@astrophpeter astrophpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Sam!

@astrophpeter astrophpeter merged commit e2e196c into main Aug 18, 2022
@astrophpeter astrophpeter deleted the Lai branch August 18, 2022 15:27
djones1040 pushed a commit that referenced this pull request Jul 30, 2023
 updates for the fixed footer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants