Implement stream interface and testing #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is much to say here, but TLDR the whole package is now fully tested, so I believe it does works at creating valid md5 from the Nifti.
There seems to be a lot going on (that's what OOP tends to do, especially in java), but it's mainly two new classes doing the same thing on different levels to keep it readable.
In the StreamUtil, you get the core stream data interface It gets you from the array data in the Nifti and Headers to bytestreams of even actual DataStreams that reprent doubles or integers.
In the NiftiStreamUtil, you get functions to unpack the NiftiVolume into the stream. Not much to say here, it's an adapter between StreamUtil and niftijio.
With that, in Methods, we get controlled streams of bytes from the header and the data to feed to an encoder that gets us the md5 in hexadecimal in a string representation. All of that without ever touching Locale or decoding anything into a charset.