Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correction version FRF (Answer issue 41) #47

Merged
merged 10 commits into from
Nov 28, 2024
Merged

correction version FRF (Answer issue 41) #47

merged 10 commits into from
Nov 28, 2024

Conversation

ThoumyreStanislas
Copy link
Contributor

#41

@ThoumyreStanislas ThoumyreStanislas requested review from arnaudbore and removed request for Manonedde November 21, 2024 22:40
@ThoumyreStanislas
Copy link
Contributor Author

forgot to update snaps sorry

@AlexVCaron
Copy link
Collaborator

AlexVCaron commented Nov 21, 2024 •
edited
Loading

Synthbet requires 8Gb of RAM and should be assigned a bigmem test runner, like easyreg. I'm not sure why it's not already the case ...

@ThoumyreStanislas
Copy link
Contributor Author

where is the tag "bigmem" in easyreg I don't remember and I don't find it @AlexVCaron

@AlexVCaron
Copy link
Collaborator

Here, copy the two lines for easyreg and adapt for the name of the synthseg module

@ThoumyreStanislas
Copy link
Contributor Author

But it is already written just above the easyreg line @AlexVCaron

@AlexVCaron
Copy link
Collaborator

AlexVCaron commented Nov 22, 2024 •
edited
Loading

I mean synthbet 😅 that was dumb, my bad ! Have that kind of entry for it as well :

- runner: scilus-nf-neuro-bigmem-runners
  path: modules/nf-neuro/betcrop/synthbet

@ThoumyreStanislas ThoumyreStanislas changed the title correction version FRF and synthbet (Answer issue 41) correction version FRF (Answer issue 41) Nov 25, 2024
gagnonanthony
gagnonanthony previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

AlexVCaron
AlexVCaron requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little thing, but I'll fix it myself from the PR 😉

@AlexVCaron AlexVCaron enabled auto-merge November 28, 2024 21:32
@AlexVCaron AlexVCaron disabled auto-merge November 28, 2024 21:32
@AlexVCaron AlexVCaron merged commit 190a65c into scilus:main Nov 28, 2024
16 checks passed
@ThoumyreStanislas ThoumyreStanislas deleted the fix-error-anthony branch February 6, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVCaron AlexVCaron AlexVCaron approved these changes

@gagnonanthony gagnonanthony gagnonanthony left review comments

@arnaudbore arnaudbore Awaiting requested review from arnaudbore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThoumyreStanislas @AlexVCaron @gagnonanthony