Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update reconst modules #33

Closed
wants to merge 12 commits into from

Conversation

Manonedde
Copy link
Contributor

@Manonedde Manonedde commented Oct 31, 2024

Filling your PR description

module/fodf:
copy alex's changes for tractoflow

Error during test - Need to be tested @arnaudbore

module/meanfrf:
copy alex's changes for tractoflow

Type of improvement

If submitting a new module or fixing a bug, please use the appropriate template.

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Write a clear and concise description of what the improvement is.

Describe how to test your improvement

Copy alex's changes for tractoflow

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@Manonedde Manonedde self-assigned this Oct 31, 2024
@Manonedde Manonedde linked an issue Oct 31, 2024 that may be closed by this pull request
8 tasks
@Manonedde Manonedde changed the title Update reconst modules [ENH] Update reconst modules Oct 31, 2024
@AlexVCaron
Copy link
Collaborator

I took the PR under my hands. There was not much left to do and I didn't want to bother you with simple git manips. I'll close this PR when #37 is merged. Thanks for all the work !

@AlexVCaron AlexVCaron mentioned this pull request Nov 19, 2024
9 tasks
@AlexVCaron AlexVCaron closed this Nov 19, 2024
@Manonedde Manonedde deleted the update_reconst_modules branch November 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port modules from AlexVCaron/nf-scil
3 participants