-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New density map module #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-management
bot
requested review from
arnaudbore and
ThoumyreStanislas
October 30, 2024 14:13
arnaudbore
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick modification and LGTM
arnaudbore
reviewed
Oct 31, 2024
arnaudbore
reviewed
Nov 1, 2024
arnaudbore
approved these changes
Nov 1, 2024
ThoumyreStanislas
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
New module to compute a density map from a bundle.
List test packages used by your module
bundle.zip
Checklist before requesting a review
./modules/nf-neuro/<category>/<tool>/main.nf
./modules/nf-neuro/<category>/<tool>/meta.yml
./modules/nf-neuro/<category>/<tool>/environment.yml
./modules/nf-neuro/<category>/<tool>/tests/main.nf.test
main.nf.test.snap
snapshotsprettier
andeditorconfig-checker
to fix common syntax issuesnf-core modules lint
and fix all errors