Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New density map module #30

Merged
merged 8 commits into from
Nov 1, 2024
Merged

Conversation

GuillaumeTh
Copy link
Contributor

@GuillaumeTh GuillaumeTh commented Oct 30, 2024

Describe your changes

New module to compute a density map from a bundle.

List test packages used by your module

bundle.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-neuro/<category>/<tool>/main.nf
    • Edit ./modules/nf-neuro/<category>/<tool>/meta.yml
    • Edit ./modules/nf-neuro/<category>/<tool>/environment.yml
  • Generate the tests:
    • Edit ./modules/nf-neuro/<category>/<tool>/tests/main.nf.test
    • Run the tests to generate the main.nf.test.snap snapshots
  • Ensure the syntax is correct :
    • Run prettier and editorconfig-checker to fix common syntax issues
    • Run nf-core modules lint and fix all errors
    • Ensure your variables have good, clear names

arnaudbore
arnaudbore previously approved these changes Oct 30, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick modification and LGTM

modules/nf-neuro/bundle/densitymap/meta.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ThoumyreStanislas ThoumyreStanislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudbore arnaudbore added this pull request to the merge queue Nov 1, 2024
Merged via the queue into scilus:main with commit 1cfdaf1 Nov 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants