Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Fix bundleseg atlas #29

Merged
merged 5 commits into from
Oct 31, 2024
Merged

[ENH] Fix bundleseg atlas #29

merged 5 commits into from
Oct 31, 2024

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Oct 30, 2024

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Fixed running subworkflow with paing atlas. Logic based on param instead of channel

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@anroy1 anroy1 changed the title [ENH]fix bundleseg atla [ENH]fix bundleseg atlas Oct 30, 2024
@anroy1 anroy1 changed the title [ENH]fix bundleseg atlas [ENH] Fix bundleseg atlas Oct 31, 2024
gagnonanthony
gagnonanthony previously approved these changes Oct 31, 2024
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG! 🍻

@arnaudbore arnaudbore self-requested a review October 31, 2024 18:31
@arnaudbore arnaudbore added this pull request to the merge queue Oct 31, 2024
Merged via the queue into scilus:main with commit eaf8d41 Oct 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants