Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Z/17 in Representative Cocycles tutorial #83

Closed
CodyArmond opened this issue Jul 19, 2019 · 2 comments
Closed

Using Z/17 in Representative Cocycles tutorial #83

CodyArmond opened this issue Jul 19, 2019 · 2 comments

Comments

@CodyArmond
Copy link

Hello, I am working on expanding the explanation of cohomology in this tutorial, but I had a question about the following statement:

The death edge between 3_8 has been removed. For the remaining triangles, we can now verify that the cocycle condition is satisfied. For instance, for triangle 0_2_11, we have 1 + 16 + 0 = 17 = 0 (mod 17). Along triangle 0_1_2 we have 0 + 1 - 1 (since the edge 2_0 is negatively oriented), which is 0 (mod 17).

The problem is that the edge 2_11 is above the threshold and not part of the simplicial complex. As it stands all edges evaluate to either 1 or 0. Has the example changed since this was written?

@ctralie
Copy link
Member

ctralie commented Aug 6, 2019

Hello,
Thank you for pointing this out, and my sincerest apologies for the delay in my response. You are absolutely right. Something got lost in translation as we were moving notebooks and code around creating the larger scikit-tda project. Please have a look at this new notebook and let me know if this example makes more sense:
https://github.com/scikit-tda/ripser.py/blob/fixingcocyclenotebook/docs/notebooks/Representative%20Cocycles.ipynb
Many thanks,
Chris

@catanzaromj
Copy link
Contributor

@ctralie This never made it into the docs. Is there any reason why not? Should I add it in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants