-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPDATE: MAPIEv1 Backend - Split .fit into .fit_single_estimator and fit_multi_estimator #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_multi_estimators
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1 #545 +/- ##
======================================
Coverage ? 100.00%
======================================
Files ? 62
Lines ? 6001
Branches ? 990
======================================
Hits ? 6001
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Valentin-Laurent
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 💪🏻
Few comments
Valentin-Laurent
approved these changes
Dec 2, 2024
Valentin-Laurent
pushed a commit
that referenced
this pull request
Dec 2, 2024
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Dec 9, 2024
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Dec 17, 2024
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
jawadhussein462
added a commit
that referenced
this pull request
Dec 20, 2024
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
jawadhussein462
added a commit
that referenced
this pull request
Dec 20, 2024
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Dec 29, 2024
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 5, 2025
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 7, 2025
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 7, 2025
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 8, 2025
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 9, 2025
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 10, 2025
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_multi_estimators
Description
This PR refactors the
MAPIE
ibrary by splitting the.fit
method inEnsembleRegressor
into two distinct methods:.fit_single_estimator
and.fit_multi_estimators
. The goal is to enhance modularity, readability, and maintainability of the codebase.This refactoring is part of an ongoing effort to align the
MAPIE
library with modern software engineering practices. It ensures better scalability, maintainability, and adaptability for future features or modifications. The changes also address the growing need to handle single and multi-estimator workflows distinctly in the library.Refactoring
.fit
Logic:.fit
method is now divided into:.fit_single_estimator
: Handles the fitting logic for a single estimator..fit_multi_estimators
: Handles the fitting logic for multiple estimators in an ensemble.Reorganization of
v0
andv1
Components:v0
**:v0.conformlize
:Combines logic for
fit_multi_estimators
and calibration-based prediction (predict_calib
).v0.fit
:Combines
fit_single_estimator
andconformlize
to handle the full fitting process.v1
:v1.fit
:Only includes
fit_single_estimator
, streamlining the single-estimator fitting process.v1.conformlize
:Retains the structure of
v0.conformlize
, combining multi-estimator fitting and prediction calibration.Type of change
Checklist
make lint
make type-check
make tests
make coverage
make doc