Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import in the ts-changepoint notebook related to conformity scores is incorrect #498

Conversation

BaptisteCalot
Copy link
Collaborator

@BaptisteCalot BaptisteCalot commented Jul 26, 2024

Description

The import in the ts-changepoint notebook related to conformity scores has been incorrect since the merge of the Mapie Classifier refactor

Fixes #497

Type of change

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

No unit test

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (ede2113).
Report is 611 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #498    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        56    +17     
  Lines         4616      5481   +865     
  Branches       487       907   +420     
==========================================
+ Hits          4616      5481   +865     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BaptisteCalot BaptisteCalot merged commit e1dd0e7 into master Aug 1, 2024
8 checks passed
@BaptisteCalot BaptisteCalot deleted the 497-import-in-the-ts-changepoint-notebook-related-to-conformity-scores-is-incorrect branch August 1, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import in the ts-changepoint notebook related to conformity scores is incorrect
3 participants