Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

473 replace assert nparray equal by nptestingassert array equal in all mapie unit tests #485

Conversation

BaptisteCalot
Copy link
Collaborator

@BaptisteCalot BaptisteCalot commented Jul 16, 2024

Description

Replace assert np.array_equal by np.testing.assert_array_equal in all Mapie unit tests

The error message returned by the function np.testing.assert_array_equal is very specific, whereas assert np.array_equal only captures a generic message like 'AssertionError'

Fixes #473

Type of change

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

No tests added

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Copy link
Collaborator

@LacombeLouis LacombeLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BaptisteCalot,
Great PR, thank you!

LacombeLouis and others added 2 commits July 17, 2024 14:59
…ingassert_array_equal-in-all-mapie-unit-tests
…ingassert_array_equal-in-all-mapie-unit-tests
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (17f56cd).
Report is 599 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #485    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        56    +17     
  Lines         4616      5481   +865     
  Branches       487       872   +385     
==========================================
+ Hits          4616      5481   +865     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BaptisteCalot BaptisteCalot merged commit 8583e6b into master Jul 23, 2024
8 checks passed
@BaptisteCalot BaptisteCalot deleted the 473-replace-assert-nparray_equal-by-nptestingassert_array_equal-in-all-mapie-unit-tests branch July 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace assert np.array_equal by np.testing.assert_array_equal in all Mapie unit tests
3 participants