Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor train-test split in plot_cqr_tutorial.py #482

Conversation

LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented Jul 5, 2024

Description

Fix issue on #477. Uses the same data and split for MapieRegressor and MapieQuantileRegressor.

Please remove options that are irrelevant.

  • This change requires a documentation update

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis marked this pull request as draft July 5, 2024 12:33
@LacombeLouis LacombeLouis marked this pull request as ready for review September 3, 2024 13:32
@LacombeLouis LacombeLouis requested review from vincentblot28 and removed request for thibaultcordier September 3, 2024 13:38
Copy link
Collaborator

@vincentblot28 vincentblot28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix !

…odel-that-used-training-and-calibration-data
@LacombeLouis LacombeLouis merged commit 6ebf607 into master Sep 3, 2024
8 checks passed
@Valentin-Laurent Valentin-Laurent deleted the 477-mapieregressor-with-prefit-optimized-model-that-used-training-and-calibration-data branch November 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapieRegressor with prefit optimized model that used training and calibration data
2 participants