Change the sign in the equation of C_k in the Kolmogorov-Smirnov statistical test documentation #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LacombeLouis
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Great! Thank you! @BaptisteCalot
Don't forget to add this to the history :)
LacombeLouis
approved these changes
Jun 25, 2024
HISTORY.rst
Outdated
| @@ -5,6 +5,7 @@ History | |||
| 0.8.x (2024-xx-xx) | |||
| ------------------ | |||
|
|
|||
| * Changed the sign of C_k in the `Kolmogorov-Smirnov` test documentation to resolve issue 369. | |||
There was a problem hiding this comment.
No need to put the issue number in history :)
BaptisteCalot
changed the title
LacombeLouis
approved these changes
Jun 25, 2024
BaptisteCalot
deleted the
369-incoherent-sign-on-mapiemetricscumulative_differences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change (y_i- s_i) instead of (s_i - y_i) in the definition of C_k
Fixes issue #369
How Has This Been Tested?
No test for this change
Checklist
make lintmake type-checkmake testsmake coveragemake doc