Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy version to 1.7.1 #399

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented Jan 11, 2024

Description

Fixing an issue with mypy. #398

Type of change

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis self-assigned this Jan 11, 2024
@LacombeLouis LacombeLouis linked an issue Jan 11, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (614293e) 100.00% compared to head (c240f85) 100.00%.
Report is 173 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #399    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        39            
  Lines         4616      4772   +156     
  Branches       487       792   +305     
==========================================
+ Hits          4616      4772   +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, this update of mypy version in the requirements is very welcome!

@LacombeLouis LacombeLouis merged commit f695b45 into master Jan 11, 2024
8 checks passed
@LacombeLouis LacombeLouis deleted the 398-mypy-version-in-the-environment-file branch April 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy version in the environment file
3 participants