Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Remove pandas in package import #396

Merged
merged 1 commit into from
Jan 8, 2024
Merged

FIX: Remove pandas in package import #396

merged 1 commit into from
Jan 8, 2024

Conversation

thibaultcordier
Copy link
Collaborator

@thibaultcordier thibaultcordier commented Jan 5, 2024 •
edited
Loading

Description

Error importing MapieTimeSeriesRegressor because pandas is not a required package in mapie. It is therefore proposed that this unnecessary dependency be removed and that only numpy arrays be managed.

Fixes #395

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Import MapieTimeSeriesRegressor without pandas requirement.

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@thibaultcordier thibaultcordier self-assigned this Jan 5, 2024
@thibaultcordier thibaultcordier added Source: contributors Proposed by contributors. Bug Type: bug Source: developers Proposed by developers. and removed Source: contributors Proposed by contributors. labels Jan 5, 2024
@thibaultcordier thibaultcordier marked this pull request as ready for review January 5, 2024 11:47
LacombeLouis
LacombeLouis approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@LacombeLouis LacombeLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Perfect, works like a charm 😃

Looking forward to 0.8.1!

@thibaultcordier thibaultcordier merged commit 19c03ff into master Jan 8, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Open
@Valentin-Laurent Valentin-Laurent deleted the 395-pandas-dependency branch November 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LacombeLouis LacombeLouis LacombeLouis approved these changes

Assignees

@thibaultcordier thibaultcordier

Labels
Bug Type: bug Source: developers Proposed by developers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError importing MapieTimeSeriesRegressor
2 participants
@thibaultcordier @LacombeLouis