Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Remove disk space regression hack fix #831

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 21, 2020

Description

The change on the VMs used for the Ubuntu builds that caused the disk space regression in PR #819 is getting rolled back (c.f. actions/virtual-environments Issue 709). As a result, the temporary hack fix of running apt-get clean before installation on the ubuntu-latest jobs is no longer necessary and can be reverted.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Revert apt-get clean hack fix for disk space regression (now resolved)
   - c.f. https://github.com/actions/virtual-environments/issues/709

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions fix A bug fix labels Apr 21, 2020
@matthewfeickert matthewfeickert self-assigned this Apr 21, 2020
@matthewfeickert matthewfeickert force-pushed the fix/rollback-disk-space-regression-hack branch from 75311a5 to 3a9f9cb Compare April 21, 2020 16:39
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #831 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files          54       54           
  Lines        3016     3016           
  Branches      424      424           
=======================================
  Hits         2893     2893           
  Misses         78       78           
  Partials       45       45           
Flag Coverage Δ
#unittests 95.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1633787...b063e77. Read the comment docs.

@matthewfeickert matthewfeickert added revert Reverts a previous commit and removed fix A bug fix labels Apr 21, 2020
@matthewfeickert matthewfeickert changed the title fix: Revert disk space regression hack fix revert: Remove disk space regression hack fix Apr 21, 2020
@matthewfeickert matthewfeickert marked this pull request as ready for review April 22, 2020 01:51
@matthewfeickert matthewfeickert requested a review from kratsg April 22, 2020 01:51
@kratsg kratsg merged commit 1af0c98 into master Apr 22, 2020
@kratsg kratsg deleted the fix/rollback-disk-space-regression-hack branch April 22, 2020 02:16
matthewfeickert added a commit that referenced this pull request Apr 22, 2020
* Revert apt-get clean hack fix for disk space regression (now resolved)
   - c.f. actions/runner-images#709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions revert Reverts a previous commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants