Add ability to pass options to SciPy minimizers #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
HDembinski
reviewed
Dec 5, 2024
HDembinski
reviewed
Dec 5, 2024
HDembinski
reviewed
Dec 5, 2024
HDembinski
reviewed
Dec 5, 2024
HDembinski
reviewed
Dec 5, 2024
HDembinski
reviewed
Dec 5, 2024
tests/test_scipy.py
Outdated
| with pytest.raises(ValueError): | ||
| m.scipy(options=[]) | ||
|
|
||
|
|
There was a problem hiding this comment.
Would be nice to also have a test cases that shows the benefit of setting options.
There was a problem hiding this comment.
I will work on adding this; the other changes have been made.
|
Thanks, I am happy to include this patch, after some refinement. |
Co-authored-by: Hans Dembinski <[email protected]>
Co-authored-by: Hans Dembinski <[email protected]>
HDembinski
reviewed
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various SciPy minimizers have different options that can be adjusted to change and improve performance. Presently, the iminuit API does not allow passing options to these minimizers, which limits their usefulness for some minimization problems (specifically mine). I added a parameter to minuit.scipy() to allow passing options to scipy.optimize.minimize(). It keeps the existing default options that were being passed and allows for these defaults to be overwritten by the user.