fix: 2881 akconcatenate fails trying to concatenate too many nested arrays #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks a bunch of old tests, but passes the original test in 2881. Needs scrutiny etc.
Expanding the template instances for: * awkward_UnionArray_nestedfill_tags_index * awkward_UnionArray_simplify_one * awkward_UnionArray_simplify These allow 64-bit tags in certain cases, for ak_concatenate.
jpivarski
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
This is looking good!
One thing that's missing is for UnionArray.simplified to document that it accepts 64-bit tags, but if the final result would be to make a UnionArray with more than more than 127 contents, it still raises an error. (And also, that check needs to be implemented.)
Also a few style modifications. The reason for moving those length checks is so that I do not wish even temporarily hold on to content tags with invalid data.
Co-authored-by: Jim Pivarski <[email protected]>
ianna
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
@tcawlfield - looks great to me! All CUDA tests pass as expected! Thanks!
tcawlfield
deleted the
2881-akconcatenate-fails-trying-to-concatenate-too-many-nested-arrays
branch
|
This is fantastic @tcawlfield ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When concatenating arrays at a depth > 0 (not outermost), current code has a limitation
of 128 arrays to be combined.
This PR relaxes that requirement.