Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support complete version specification syntax for CMake and ninja versions #583

Closed
vyasr opened this issue Dec 21, 2023 · 0 comments · Fixed by #602
Closed

Support complete version specification syntax for CMake and ninja versions #583

vyasr opened this issue Dec 21, 2023 · 0 comments · Fixed by #602

Comments

@vyasr
Copy link
Contributor

vyasr commented Dec 21, 2023

Currently scikit-build-core supports specifying minimum required CMake and ninja versions in pyproject.toml. While this may be sufficient most of the time, sometimes more precise version requests are necessary. It would be good for scikit-build-core to support full version specs here.
@vyasr vyasr mentioned this issue Dec 21, 2023
Closed
@henryiii henryiii mentioned this issue Jan 3, 2024
Merged
henryiii added a commit that referenced this issue Jan 5, 2024
@henryiii
feat: cmake.version and ninja.version (#602)
f8c5798 
Close #583.

If `tool.scikit-build.minimum-version` is set, then this will require
the correct setting here. If it's unset, it will just produce a warning
if the old form is used (for now).

This is also an API change, but I think that's fine for a 0.x release
unless someone needs back-compat, which I can add if needed.

Signed-off-by: Henry Schreiner <[email protected]>
@vyasr vyasr mentioned this issue May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cmake.version and ninja.version scikit-build/scikit-build-core
1 participant
@vyasr