Skip to content

Commit

Permalink
fix: only set the lib for FindPython on Windows (#285)
Browse files Browse the repository at this point in the history
Fixes #283.  Ideally this needs to be fixed upstream.

Signed-off-by: Henry Schreiner <[email protected]>
  • Loading branch information
henryiii authored Apr 16, 2023
1 parent 7bac01c commit a44fbc6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/scikit_build_core/builder/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ def configure(
cache_config[f"{prefix}_ROOT_DIR"] = sys.prefix
cache_config[f"{prefix}_INCLUDE_DIR"] = python_include_dir
cache_config[f"{prefix}_FIND_REGISTRY"] = "NEVER"
if python_library:
# FindPython may break if this is set - only useful on Windows
if python_library and sys.platform.startswith("win"):
cache_config[f"{prefix}_LIBRARY"] = python_library

if limited_abi:
Expand Down

0 comments on commit a44fbc6

Please sign in to comment.