Upgrade to Rails 8 #2816
Draft
Upgrade to Rails 8 #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochkind
force-pushed
the
rails8_experiment
branch
from
8737d65 to
ff8b51f
Compare
…o nil, we should say that
… we like It resulted in deprecation warning: ``` DEPRECATION WARNING: `rails/console/methods` has been deprecated and will be removed in Rails 8.1. Please directly use IRB's extension API to add new commands or helpers to the console. For more details, please visit: https://github.com/ruby/irb/blob/master/EXTEND_IRB.md ``` But we didn't need the require at all in Rails 8 to patch what we wanted to patch -- not sure if extension API would let us or be appropriate to patch what we want, but this seems to be working.
jrochkind
force-pushed
the
rails8_experiment
branch
from
ff8b51f to
353d475
Compare
|
This looks like a small PR, but it's because of lots of work finding problems and separating solutions into previous PR's that already went in, that would work in both Rails 7 and 8. |
|
Note a patch to Devise to make it work with Rails 8 before they release a version with the fix! |
|
@eddierubeiz I'm not going to merge until after the new year, but avail for review whenever! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream merged but unreleased devise patch to work with Rails 8: heartcombo/devise#5728