Print returned TTL value #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalves599
force-pushed
the
show-ttl-flag
branch
from
e4a573a to
c45534f
Compare
|
Thanks for this pull request! I have started looking at the changes and will provide a first review soon. |
auerswal
requested changes
Aug 24, 2024
nalves599
force-pushed
the
show-ttl-flag
branch
from
c45534f to
d947932
Compare
nalves599
force-pushed
the
show-ttl-flag
branch
from
d947932 to
a88a0d9
Compare
auerswal
reviewed
Aug 24, 2024
nalves599
force-pushed
the
show-ttl-flag
branch
from
a88a0d9 to
343523f
Compare
auerswal
requested changes
Aug 24, 2024
Co-authored-by: Luís Fonseca <[email protected]>
nalves599
force-pushed
the
show-ttl-flag
branch
from
343523f to
ddf417e
Compare
auerswal
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
I'd say this looks mostly OK.
The commit message could be a bit more explicit that this introduces a new option, but then your example commit has a similarly brief commit message.
I'll wait a bit before merging. This allows me to think more about the pull request, and gives others an opportunity to look at it, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print the returned TTL value from the IP header.