Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an ability to avoid "/-" if no max value is set. #138

Closed
amanenk opened this issue Sep 30, 2022 · 4 comments
Closed

Add an ability to avoid "/-" if no max value is set. #138

amanenk opened this issue Sep 30, 2022 · 4 comments
Assignees
@mcamou

Comments

@amanenk
Copy link

amanenk commented Sep 30, 2022

that would be nice to have an option of having something like below
/ Syncing items... (24, 23 items/min) [1m2s]
instead of
/ Syncing items... (24/-, 23 items/min) [1m2s]
@amanenk amanenk mentioned this issue Sep 30, 2022
Closed
@schollz
Copy link
Owner

schollz commented May 20, 2024

would accept PR

@mcamou
Copy link
Contributor

mcamou commented Oct 24, 2024

@schollz I'd like to try my hand at this as part of Hacktoberfest, could you please assign me?

@schollz
Copy link
Owner

schollz commented Oct 24, 2024

@mcamou done

@mcamou
Copy link
Contributor

mcamou commented Oct 25, 2024

@schollz PR here: #205

I looked at #139 but thought that ease of use trumps flexibility, WDYT?

schollz added a commit that referenced this issue Oct 25, 2024
@schollz
Merge pull request #205 from mcamou/add-no-count-option
dcad234 
Fixes #138: Add OptionShowTotal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcamou mcamou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Add ability to use custom style for bytes showing amanenk/progressbar
3 participants
@mcamou @schollz @amanenk