Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate non python dependencies #5

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

milan-tom
Copy link
Contributor

Summary

This uses the pypdfium2 module to eliminate the non-python module dependencies (pdftk and poppler_utils) in the pdfdeanimate-image.py script and improve performance.

Benefits

  • Makes pdfdeanimate-image.py script much easier to set up and use for those who don't use nix-shell (can now install dependencies using pip install -r requirements.txt).
  • Performance of the script significantly improved.
  • No longer any need for creating an intermediate folder to store PDF page images.

Problems

  • pypdfium2 has not yet been packaged for nix-shell, so this would have to be installed manually by nix-shell users.

@milan-tom milan-tom changed the title Eliminate non python deps Eliminate non python dependencies Apr 2, 2024
@schokotets schokotets merged commit 039c7a7 into schokotets:main Apr 4, 2024
@schokotets
Copy link
Owner

i merged this. thanks for your contribution!

@milan-tom milan-tom deleted the eliminate-non-python-deps branch April 5, 2024 08:52
@milan-tom milan-tom mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants