Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Nested lists #7

Closed
kimisgold opened this issue Jan 31, 2018 · 13 comments
Closed

Feature request: Nested lists #7

kimisgold opened this issue Jan 31, 2018 · 13 comments

Comments

@kimisgold
Copy link

kimisgold commented Jan 31, 2018

My project uses drag-and-drop interfaces that are not currently accessible, and I'd love to use dragon drop to replace our current sorting jquery plugin. Many of our interfaces are for creating navigation lists, and so the ability to nest the sortable items is key.

@schne324
Copy link
Owner

schne324 commented Feb 1, 2018

This sounds interesting. Could you go more in depth on how this interaction works? I would like to get a better idea of what this feature would entail.

Screenshots would be helpful too!

@itsterry
Copy link

itsterry commented Feb 1, 2018

+1 for this feature

I've attached a screenshot from a project on which I'm currently working, using a tree structure to manage page position for a website's navigation

In it, the Events page has 3 child pages, called (imaginatively) Event 1, Event 2, and Event 3

I'd love to be able to drag Event 3 to above -say- Event 1 without being able to drag it into Resources (the item above Events) or Faqs (the Item below Events)

Hope it helps!
cms

@schne324
Copy link
Owner

schne324 commented Feb 2, 2018

Ok, thanks for the explanation + screenshot. I'll probably tag a new release including this feature this evening or tomorrow

p.s. the feature is sitting in this branch. I just need to write some tests and then tag the release

@itsterry
Copy link

itsterry commented Feb 3, 2018

Awesomely quick! Thank you! I'll check it out

@schne324
Copy link
Owner

schne324 commented Feb 3, 2018

This isn't quite resolved yet, I've added keyboard support for nested lists but not mouse support yet

@schne324
Copy link
Owner

schne324 commented Feb 3, 2018

@kimisgold @itsterry version 3.2.1 supports nested lists there is now also a demo

For now, sublists are locked (as in you can't move an item from one sublist to another but you can reorder sublist items within their original list containers). From what I gathered, this is @itsterry 's desired behavior. I do however plan on supporting the use case of moving sublist items between sublists. See #11 to track that feature.

I will close this issue if this is what both of you had in mind

@itsterry
Copy link

itsterry commented Feb 3, 2018

@schne324 Awesome: this is exactly what we need. Thank you!

@schne324
Copy link
Owner

schne324 commented Feb 3, 2018

No problem, the configuration needed is a little funky for now. Once I address #11 it should be a little more intuitive.

Cheers!

@schne324
Copy link
Owner

schne324 commented Feb 7, 2018

@kimisgold is this the kind of nesting you were looking for?

@kimisgold
Copy link
Author

Hi @schne324, thanks for the fast response on this! My use case is more like what you described, in that I need to be able to to move items in and out of sublists. For an example, you can look at our demo sandbox: http://dev.omeka.org/omeka-s-sandbox/admin/site/s/americanart/navigation (username/password: [email protected]/omekasdemo1). We're currently using jstree as our sorting tool.

@schne324
Copy link
Owner

schne324 commented Feb 8, 2018

@kimisgold this feature sounds cool but may require some decent refactoring. I'll leave this ticket open until full nested lists support is added

@kimisgold
Copy link
Author

Thanks, I look forward to seeing what you do!

@schne324
Copy link
Owner

schne324 commented Feb 8, 2018

closing in favor #11 which has a more descriptive title

@schne324 schne324 closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants