Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Navigator context #3

Merged
merged 2 commits into from
Dec 7, 2012
Merged

WIP Navigator context #3

merged 2 commits into from
Dec 7, 2012

Conversation

adrienbrault
Copy link
Contributor

Hey,

Following schmittjoh/JMSSerializerBundle#239 , here's a new PR.

A test is failing and I currently do not get why.

@schmittjoh
Copy link
Owner

My guess is that this is a PHPUnit error.

I've debugged the $this->callback() callback, and it is called 3-times while the mock method is only called once (at least the $this->once() restriction does not yield any error).

@schmittjoh schmittjoh mentioned this pull request Dec 7, 2012
Closed
@adrienbrault
Copy link
Contributor Author

@schmittjoh I changed/added some tests

schmittjoh added a commit that referenced this pull request Dec 7, 2012
@schmittjoh
Merge pull request #3 from adrienbrault/navigator-context
0899004 
Navigator context
@schmittjoh schmittjoh merged commit 0899004 into schmittjoh:master Dec 7, 2012
@schmittjoh
Copy link
Owner

Thanks!

@adrienbrault adrienbrault mentioned this pull request Dec 7, 2012
Merged
@diegosm diegosm mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrienbrault @schmittjoh