Deprecate @ReadOnly annotation in favor of @ReadOnlyProperty
#1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
commented
Jul 31, 2021
| * @Annotation | ||
| * @Target({"CLASS","PROPERTY"}) | ||
| */ | ||
| /* final */ class ReadOnlyProperty |
There was a problem hiding this comment.
This is purposefully left as not final and only annotated @final to help with B/C and code complexity. Otherwise, there'd have to be a lot of PHP version conditionals and checks for both annotation classes. In 4.0, when the deprecated @ReadOnly annotation is removed the final should be uncommented.
There was a problem hiding this comment.
makes sense! i'm ok with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
readonlybecoming a keyword in PHP 8.1 thanks to the addition of readonly properties, classes can no longer use it as a name. This means the@ReadOnlyannotation can't be used with PHP 8.1. As suggested in the issue, this PR creates a new@ReadOnlyPropertyannotation and deprecates the existing@ReadOnlyannotation.