Updated suggestion for JsonSerializationVisitor::addData replacement
#1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `:visitProperty(new StaticPropertyMetadata('', 'name', 'value), null)` the
`\JMS\Serializer\GraphNavigator\SerializationGraphNavigator::accept()` method is called with `$data = null`, therefore `$type` will be set to `null`. Therefore, value configured in `StaticPropertyMetadata` will not be put in place (as long as it's not `null`).
In order to make `\JMS\Serializer\GraphNavigator\SerializationGraphNavigator::accept()` extract the correct type (via `gettype()`), the value needs to be set into `visitProperty()`.
In conclusion, you should use `:visitProperty(new StaticPropertyMetadata('', 'name', null), 'value')`
|
@kunicmarko20 As I remember, you made a PR about this months ago.. any comment? |
|
Yes, and this is exactly the change I am using, forgot to make a PR. @theoboldt there is a code comment explaining this also, can you find that one and update it too. |
|
serializer/src/JsonSerializationVisitor.php Line 169 in d12427b |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
:visitProperty(new StaticPropertyMetadata('', 'name', 'value), null)the\JMS\Serializer\GraphNavigator\SerializationGraphNavigator::accept()method is called with$data = null, therefore$typewill be set tonull. Therefore, value configured inStaticPropertyMetadatawill not be put in place (as long as it's notnull).In order to make
\JMS\Serializer\GraphNavigator\SerializationGraphNavigator::accept()extract the correct type (viagettype()), the value needs to be set intovisitProperty().In conclusion, you should use
:visitProperty(new StaticPropertyMetadata('', 'name', null), 'value')