-
-
Notifications
You must be signed in to change notification settings - Fork 588
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix DocBlockTypeResolver crash on PHP 7.3 and less
- Loading branch information
Showing
2 changed files
with
39 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace JMS\Serializer\Tests\Fixtures; | ||
|
||
// phpcs:disable | ||
final class ObjectWithPhpDocProperty | ||
{ | ||
/** | ||
*/ | ||
private $emptyBlock; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace JMS\Serializer\Tests\Metadata\Driver; | ||
|
||
use JMS\Serializer\Metadata\Driver\DocBlockTypeResolver; | ||
use JMS\Serializer\Tests\Fixtures\ObjectWithPhpDocProperty; | ||
use PHPUnit\Framework\TestCase; | ||
use ReflectionProperty; | ||
|
||
final class DocBlockTypeResolverTest extends TestCase | ||
{ | ||
public function testGetPropertyDocblockTypeHintDoesNotCrash(): void | ||
{ | ||
// It crashed on PHP 7.3 and less because of array_merge(...[]) | ||
|
||
$resolver = new DocBlockTypeResolver(); | ||
self::assertNull( | ||
$resolver->getPropertyDocblockTypeHint( | ||
new ReflectionProperty(ObjectWithPhpDocProperty::class, 'emptyBlock') | ||
) | ||
); | ||
} | ||
} |