Remove vaultError, failedSibling and messagePassthru

1. `vaultError` and `failedSibling` are safe to remove see
https://github.com/hashicorp/nomad/blob/64e9cf9/nomad/structs/structs.go#L3979-L3986

ui/app/models/task-event.js

@@ -24,7 +24,5 @@ export default Fragment.extend({
   taskSignal: attr('string'),
   taskSignalReason: attr('string'),
   validationError: attr('string'),
-  vaultError: attr('string'),
   message: attr('string'),
-  failedSibling: attr('string'),
 });

ui/mirage/factories/allocation.js

@@ -18,9 +18,6 @@ export default Factory.extend({
   clientStatus: faker.list.random(...CLIENT_STATUSES),
   desiredStatus: faker.list.random(...DESIRED_STATUSES),
 
-  // Meta property for hinting at task events
-  useMessagePassthru: false,
-
   withTaskWithPorts: trait({
     afterCreate(allocation, server) {
       const taskGroup = server.db.taskGroups.findBy({ name: allocation.taskGroup });
@@ -79,7 +76,6 @@ export default Factory.extend({
       server.create('task-state', {
         allocation,
         name: server.db.tasks.find(id).name,
-        useMessagePassthru: allocation.useMessagePassthru,
       })
     );
 

ui/mirage/factories/task-event.js

@@ -7,12 +7,6 @@ const STATES = provide(10, faker.system.fileExt.bind(faker.system));
 export default Factory.extend({
   type: faker.list.random(...STATES),
 
-  // Message is a function of type, and this type uses the vanilla
-  // message property.
-  messagePassthru: trait({
-    type: 'Task Setup',
-  }),
-
   signal: () => '',
   exitCode: () => null,
   time: () => faker.date.past(2 / 365, REF_TIME) * 1000000,
@@ -26,6 +20,5 @@ export default Factory.extend({
   setupError: () => '',
   taskSignalReason: () => '',
   validationError: () => '',
-  vaultError: () => '',
   message: () => faker.lorem.sentence(),
 });

ui/mirage/factories/task-state.js

@@ -14,13 +14,11 @@ export default Factory.extend({
     return new Date(this.startedAt + Math.random(1000 * 60 * 3) + 50);
   },
 
-  useMessagePassthru: false,
-
   afterCreate(state, server) {
     const props = [
       'task-event',
       faker.random.number({ min: 1, max: 10 }),
-      state.useMessagePassthru && 'messagePassthru',
+      false,
       {
         taskStateId: state.id,
       },

ui/tests/acceptance/allocation-detail-test.js

@@ -14,17 +14,13 @@ moduleForAcceptance('Acceptance | allocation detail', {
 
     node = server.create('node');
     job = server.create('job', { groupCount: 0 });
-    allocation = server.create('allocation', 'withTaskWithPorts', {
-      useMessagePassthru: true,
-    });
+    allocation = server.create('allocation', 'withTaskWithPorts');
 
     visit(`/allocations/${allocation.id}`);
   },
 });
 
-test('/allocation/:id should name the allocation and link to the corresponding job and node', function(
-  assert
-) {
+test('/allocation/:id should name the allocation and link to the corresponding job and node', function(assert) {
   assert.ok(
     find('[data-test-title]').textContent.includes(allocation.name),
     'Allocation name is in the heading'
@@ -125,9 +121,7 @@ test('each task row should list high-level information for the task', function(a
   });
 });
 
-test('when the allocation is not found, an error message is shown, but the URL persists', function(
-  assert
-) {
+test('when the allocation is not found, an error message is shown, but the URL persists', function(assert) {
   visit('/allocations/not-a-real-allocation');
 
   andThen(() => {

ui/tests/acceptance/task-detail-test.js

@@ -12,18 +12,14 @@ moduleForAcceptance('Acceptance | task detail', {
     server.create('agent');
     server.create('node');
     server.create('job', { createAllocations: false });
-    allocation = server.create('allocation', 'withTaskWithPorts', {
-      useMessagePassthru: true,
-    });
+    allocation = server.create('allocation', 'withTaskWithPorts');
     task = server.db.taskStates.where({ allocationId: allocation.id })[0];
 
     visit(`/allocations/${allocation.id}/${task.name}`);
   },
 });
 
-test('/allocation/:id/:task_name should name the task and list high-level task information', function(
-  assert
-) {
+test('/allocation/:id/:task_name should name the task and list high-level task information', function(assert) {
   assert.ok(find('[data-test-title]').textContent.includes(task.name), 'Task name');
   assert.ok(find('[data-test-state]').textContent.includes(task.state), 'Task state');
 
@@ -119,9 +115,7 @@ test('the events table lists all recent events', function(assert) {
   );
 });
 
-test('each recent event should list the time, type, and description of the event', function(
-  assert
-) {
+test('each recent event should list the time, type, and description of the event', function(assert) {
   const event = server.db.taskEvents.where({ taskStateId: task.id })[0];
   const recentEvent = findAll('[data-test-task-event]').get('lastObject');