Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module support, don't leak to window #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Module support, don't leak to window #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/substituteteacher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
(function(window) {
/* */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

"format cjs";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it important / necessary to specify CommonJS format? I might just be unaware

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you don't have to specify it directly, most tools will auto-detect or default to it, but, it's better to be explicit, also with this pull you're supporting CJS, but also allowing AMD and global export so this avoids any conflicts I guess.

(function(global) {

"use strict";

Expand Down Expand Up @@ -934,6 +936,11 @@
return width;
};

window.Sub = Sub;

}(window));
if (typeof define === 'function' && define.amd) {
define(Sub);
} else if (typeof module !== 'undefined' && module.exports) {
module.exports = Sub;
} else {
global.Sub = Sub;
}
}(this));
Loading