Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video player update #58

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Video player update #58

merged 3 commits into from
Nov 20, 2020

Conversation

kawa89
Copy link
Collaborator

@kawa89 kawa89 commented Nov 20, 2020

No description provided.

@kawa89 kawa89 merged commit 5e54fb9 into dev Nov 20, 2020
@kawa89 kawa89 deleted the video_player_update branch November 20, 2020 13:22
@erickok
Copy link
Contributor

erickok commented Nov 27, 2020

Hi @kawa89 , may I ask why you changed to better_player? Sure, chewie had a delay in picking up video_player 1.0.x (but they are there now) but better_player has still has the issue with new releases that target iOS 14 just like chewie had before: fluttercommunity/chewie#381 In other words, upgrading our app to tweet_ui 2.4.x causes our app to be rejected by Apple.

@kawa89
Copy link
Collaborator Author

kawa89 commented Nov 30, 2020

Hi. I tried upgrading chewie, but there were some problems with it and I've found better_player that solved that problem.
I see that they fixed this (jhomlala/betterplayer#151) issue. I will prepare a new version of tweet_ui today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants