This repository has been archived by the owner on Oct 6, 2022. It is now read-only.
Build optiomization fork #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-ios into build-optimization
|
😡 |
Looked like there was a decent amount of unsynchronized access of data in the tests. Typical things included declaring arrays on the main thread and appending to them in a callback (that's not guaranteed to land on the main thread) And then the Testing Networking Proxy also had a slight bug that stored the call data after the completion callback was given to the client. So I divided the calldata in to request data that is guaranteed to be there before the client completion block is called but after the networking proxy actually makes the call, and a responses object which is separate an only available upon return of the callback
aliak00
force-pushed
the
build-optiomization-fork
branch
from
7ab694e to
3ee4483
Compare
For some silly reason, a task manager was for a user inside the protocol and stored in a map, but the idiot who wrote it didn't realize that user already has a taskManager so there's no reason to do that. Also the executor in the TaskOperation had a redundant done callback that just set isFinished to true immdiately after going in the execution block. So removed that
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-459107
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see how this goes...