This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
IDMOB-10 Functionality for Apple account consolidation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikaoj check this out please. |
danielschibsted
force-pushed
the
danlazar/IDMOB-10/2
branch
from
9af77d6 to
fcff1a6
Compare
|
Looks solid...would it at all be possible to write tests for this..? |
|
Added a commit with tests. |
|
👍 🍰 |
When moving an app from one Apple account to another it's not possible to keep the keychain data. If the data is not there, a logged in user will not be logged in anymore. To overcome this the move can be planned in 2 steps: 1. In the first step an app is upgraded on the old Apple account with a mode SPiDTokenStorageModeMigratePreITunesAccountMove to export keychain data to NSUserDefaults. 2. The next step is an app upgrade on to the new Apple account with a mode SPiDTokenStorageModeMigratePostITunesAccountMove to import data from NSUserDefaults. Both versions should stay in the store for a while until the most users are able to upgrade and run it. Tests: * SPiDTokenStorageTests * SPiDTokenStorageUserDefaultsBackendTests
danielschibsted
force-pushed
the
danlazar/IDMOB-10/2
branch
from
3849a84 to
7b64549
Compare
|
Great, thanks! I'll try to tag and push a version later today! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving an app from one Apple account to another
it's not possible to keep the keychain data.
If the data is not there, a logged in user will not be logged in anymore.
To overcome this the move can be planned in 2 steps:
with a mode SPiDTokenStorageModeMigratePreITunesAccountMove to export keychain data to NSUserDefaults.
with a mode SPiDTokenStorageModeMigratePostITunesAccountMove to import data from NSUserDefaults.
Both versions should stay in the store for a while
until the most users are able to upgrade and run it.