Synchronous Outlet for zero-copying socket writing #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboulay
force-pushed
the
tstenner/outlet_sync
branch
from
90c35a8 to
a3322ae
Compare
cboulay
force-pushed
the
tstenner/outlet_sync
branch
from
7e39ee6 to
4f32e15
Compare
…le of buffers. raw buffs use void**; incorporate other suggestions from tstenner. Currently not working properly!
…-ref instead of by val.
Loading the log settings last causes heaps of INFO messages to be displayed by lsl::get_local_interfaces() even if the user has set log level to -3. Changing the order causes less ui clutter and respects the users choices.
cboulay
force-pushed
the
tstenner/outlet_sync
branch
from
8e9e44f to
2c836d6
Compare
|
I just tested this in a specific application where the main branch works but this one doesn't. When receiving over pylsl, but not a C++ lib, there seemed to be some data type conversion issue. |
|
Could you add some stacktraces or a MRE? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #153
Please refer to that now-defunct PR and its conversation.